[Mod]ActivityPub Federation for SMF 2.1

[SMFHacks]

Any errors in the error_log for this or anything you can see

Code: [Select]

So the current failure appears to be occurring after activitypub_create_object_from_message() returns, likely in the subsequent Create/Announce activity construction or delivery/queuing code.

[Moobythegoldensock]

The only one that was natively throwing errors were likes. After I installed, likes weren’t saving and it was tossing errors in the log (I didn’t save those, sorry.)

What I figured out was that the ActivityPub hook in Subs-ActivityPub.php was directly accessing $obj->_content and $obj->_type, but those properties are protected in my version of Likes.php. Likes provides the public get() method for accessing them.

I changed:

Code: [Select]

$content_id = $obj->_content;
$content_type = $obj->_type;
to:

Code: [Select]

$content_id = $obj->get('content');
$content_type = $obj->get('type');
That seems to have fixed it.

Posting wasn’t throwing any actual errors, Acrivitypub was just showing 0 posts. I entered logging lines into the mod pages to try and figure out where it was tripping up.

My logs showed that the ActivityPub hook runs immediately after db_insert, while topicOptions['id'] is still 0. The immediate message lookup consequently returned the new message with id_topic=0, and the first test produced:

Code: [Select]

object lookup rows=0
On a later test, the object lookup succeeded and activitypub_serialize_note() returned a non-empty array, so the serializer itself appears to be working.

The relevant sequence for the failing post was:

Code: [Select]

after db_insert msg_id=981446
topicOptions[id]=0
immediate message found ... id_topic=0
calling object creator with msg ID=981446
object lookup rows=0
object return type=boolean
object empty=YES

[SMFHacks]

Great feedback updated with the previously mentioned issues.

Their is a new hook registered at install time, so their existing installation won't pick it up from a file update alone. Reinstall the mod, or register the hook once on their live board,
  e.g. via a quick script:

Code: [Select]

  add_integration_function('integrate_create_topic', 'activitypub_create_topic', true, '$sourcedir/Subs-ActivityPub.php', false);


[Moobythegoldensock]

Cool! I won't have time to test again until next week, but I'll let you know how the update goes.

[Moobythegoldensock]

Current version is missing .well-known directory.

[SMFHacks]

Fixed bad habit of trying to skip files that start with a period.

[Moobythegoldensock]

Installed newest version, had to edit the install.xml again to get the admin area. I can only see the toggle to use my account on ActivityPub on admin account, and when I open permissions I generate errors 2: Undefined array key "permissionname_activitypub_admin" and 2: Undefined array key "permissiongroup_activitypub"

Posts seem to be logging on SMF's end, haven't tried to access from a Lemmy client yet.

[SMFHacks]

What change did you make for the edit?

[Moobythegoldensock]

The same one from earlier:

Code: [Select]

db_extend('packages');

if (!isset($smcFunc['db_create_table']))
die('ActivityPub installer: db_create_table is NOT available');

[SMFHacks]

hmm i thought i added
db_extend('packages');
 to install.php

[Moobythegoldensock]

I’m also not able to find my forum from Lemmy. My webhost had Cloudflare on the domain: I’m wondering if that’s the issue?

I tried !board@forumaddress and got 404

[SMFHacks]

Do you have a link to Lemmy want to do some more testing.

[Moobythegoldensock]

Sure:

https://isgodimaginary.com/forum?action=activitypub;sa=actor;type=board;id=1

I’m assuming I’d search for !religion@isgodimaginary.com from Lemmy?

[GroupNebula563]

Hey! It may be worthwhile to implement /.well-known/nodeinfo endpoints so that, for instance, the forum can be easily searched for on ActivityPub directories. For example: https://lemmy.world/.well-known/nodeinfo and https://lemmy.world/nodeinfo/2.1 (not all fields need to be populated, just the ones you can with existing SMF data)

[SMFHacks]

Interesting that is something I will need to research more.