SMFHacks.com

Downloads System Pro => Support => Bugs => Topic started by: Paddleducks Forum - Damien on November 25, 2010, 02:51:07 am

Title: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on November 25, 2010, 02:51:07 am
Just upgraded everything to the latest versions, and now every file area I have is displayed twice - Even though they are only listed once in the database....

I also use membergroups to limit access - those with less than 3 posts are "newbie" and they should only be able to view files, NOT download - That worked fine with my previous version of Downloads Pro, but with 2.0 they can now download, which shouldn't be allowed!

www.paddleducks.co.uk

Any help would be appreciated...

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on November 25, 2010, 02:55:31 am
I've just noticed that the file areas are only being displayed twice for Admins - If I login as a normal user they are only displayed once....

The bug which is allowing people to download is still there however :(

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Hally_89 on November 25, 2010, 07:55:49 am
Hi i bought the downloads pro system back in july but only registered now to get the updated version. Do i need to make 3 posts before i can download the latest version? If not can you please tell me where to get it. I have added my license key under the licence tab in the menu. Thanks
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: SMFHacks on November 25, 2010, 09:47:32 am
Hi i bought the downloads pro system back in july but only registered now to get the updated version. Do i need to make 3 posts before i can download the latest version? If not can you please tell me where to get it. I have added my license key under the licence tab in the menu. Thanks
You can download it at
http://www.smfhacks.com/index.php/topic,3489.0.html
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Hally_89 on November 25, 2010, 09:50:05 am
Thank you i overlooked that topic somehow
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: SMFHacks on November 25, 2010, 11:03:54 am
Eddy try this file for duplicate categories/files attached

Category level permisions work like this
First checks additional membergroups that a user will have. If any of those return true the permission is allowed.
Then checks the main primary group. If any of those return true the permission is allowed.
Last it checks Post Group if that returns true then it is allowed.
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on November 25, 2010, 11:16:12 am
Thanks SMF - The upgraded file sorted the duplicate categories perfectly.....

I'll double check all the permissions to make sure I don't have anything setup wrongly, and let you know how that goes...

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on November 26, 2010, 04:13:05 pm
Eddy try this file for duplicate categories/files attached

Category level permisions work like this
First checks additional membergroups that a user will have. If any of those return true the permission is allowed.
Then checks the main primary group. If any of those return true the permission is allowed.
Last it checks Post Group if that returns true then it is allowed.

Hmmm...

I don't use additional membergroups, so that doesn't apply....

In Downloads Pro I have "Regular Users" set to allow 2 downloads per day, as it doesn't allow me to set that for "Post groups".

Then I have numerous "Post groups" set depending (obviously) on how many messages have been posted - The first one is "Newbie" for new users that have posted less than 3 messages - Downloads Pro is set to allow them to view the files, but NOT download.

But sadly they CAN download with Downloads Pro v2.0 :(

The previous beta version I used worked perfectly (sorry I cannot remember the version number), and apart from upgrading to SMF v2.0 RC4 and Downloads Pro v2.0, I haven't changed any settings, so I can only assume that the code in Downloads Pro has been changed and it no longer works as it did....

So from what you've said I'm assuming it should work as follows....

Additional membergroups - Don't exist, so ignore...
Primary membergroup = Regular user - So allow....
Post Group = Newbie - So deny downloads...

But that isn't what's happening :(

Can you take a look at this please SMF?

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: SMFHacks on November 27, 2010, 04:26:47 pm
Just spent a couple hours going to have to rework it completely. Turns out the additional checks for other membergroups include post based groups as well so going to have redo it.
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: SMFHacks on November 27, 2010, 05:06:36 pm
Try this file and let me know the results
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on November 27, 2010, 05:07:14 pm
Just spent a couple hours going to have to rework it completely. Turns out the additional checks for other membergroups include post based groups as well so going to have redo it.

Sorry to give you extra work SMF :(

Thanks for checking it all out....

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on November 27, 2010, 05:08:06 pm
Try this file and let me know the results

I'll take a look at that tomorrow afternoon, just about to go to bed now....

Many thanks
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on November 28, 2010, 02:26:52 am
I've just installed the latest downloads2.php file, and it appears to have sorted the problem SMF.... Admittedly I've only done a few quick tests, but it looks good so far.

Many thanks
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on December 01, 2010, 03:15:16 am
Another small problem SMF.....

I have a Primary Membergroup called "No Downloads" to block those that are only there to take and take.....

In category permissions, this membergroup can view files, but CANNOT download. But Downloads Pro v2.0 is allowing them to download because their Post Count group says they have posted enough messages.

I think that Downloads Pro should check Primary Group, Additional Groups, and then Post Count Groups.... If ANY of those say "Deny" then it should exit the checking routine...

ie:

Check Primary membergroup - If "allowed" OR if no primary group exists then check Additional membergroups, if "Deny" then exit...

Check Additional membergroups - If "Allowed" OR If no Additional membergroup exists then check Post groups. If "Deny" then exit....

Check Postgroups - If "Deny" then exit....

In other words, if ANY of the groups say the member is "Denied" downloads, then they should NOT be able to download.

I hope that makes sense? This all worked perfectly in an earlier beta release, and none of my settings have been altered since upgrading.

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: SMFHacks on December 01, 2010, 07:51:59 pm
I have to think about that case a little more. By default with SMF I think is if any group has access to it they are marked as allowed.
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Matth41 on December 01, 2010, 09:21:28 pm
My understanding of the DENY permission is that it takes priority over permissions assigned by any other group.
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on December 03, 2010, 12:00:46 pm
My understanding of the DENY permission is that it takes priority over permissions assigned by any other group.

That's what I thought Matth, with the current settings in Downloads Pro, PostGroup settings will ALWAYS take priority, which is plainly wrong.....

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on December 05, 2010, 02:13:57 pm
Any update to this issue SMF? It really is becomming a problem for me....

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: SMFHacks on December 05, 2010, 05:27:17 pm
You can try this.
I am just thinking ahead I am going to run into other issues that users who deny one group but allow another so really confuses me what to do.
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on December 05, 2010, 05:48:03 pm
Thanks SMF, I'll give it a try and see what happens.....

To me it seems simple - Primary membergroups should take priority, then Additional membergroups, and finally Postgroups....

And the default setting should be "Deny"....

So if the Primarygroup says deny, STOP checking, that's it!
If Additional membergroup says deny, STOP checking any further... However, if there is NO additional group specified AND Primary says Allow, then check Postgroups.
And finally, check Postgroups, but ONLY if Primary and/or Additional Allow it...

At least that's the way I would say things should work....

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on December 06, 2010, 01:45:36 pm
Sorry SMF, that doesn't work....

If the user has PrimaryMembergroup set to "Deny", and thier Postgroup says "Allow", then they can download, so the Postgroup is overriding every other setting :(

In fact after more testing, it seems to be allowing anyone to download, even if thier Postgroup says "Deny" :(

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: Paddleducks Forum - Damien on December 11, 2010, 03:20:07 am
Just wanted to jog your memory SMF, I'm still waiting patiently......  :D

Regards
Eddy
Title: Re: Downloads Pro with SMF 2.0Rc4
Post by: SMFHacks on December 11, 2010, 12:48:05 pm
Retry reuploaded the file made another change