SMFHacks.com

Menu Editor Pro => Support => Bug Reports => Topic started by: LukeZ on September 23, 2015, 07:13:12 pm

Title: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on September 23, 2015, 07:13:12 pm
Hi, I bought the Pro version of this specifically because it said it was compatible with Simple Portal, which the Lite version is not. I'm using SMF 2.0.11 and Simple Portal 2.3.6. I have Simple Portal set to Standalone mode with the standalone URL being the root of my domain. I renamed StandalonePortal.php to index.php and put this at the root. Worked fine until I installed Menu Editor Pro.

If I try to add a menu button with internal action to Portal Home, it lets me do it but I can't set "Is Active" to yes. Instead it gives me a message: "The portal button can only be set to non-active if the Portal Front Page setting is not on."

I've tried changing Simple Portal to "Front Page" mode from "Standalone" and it makes no difference.

Then I thought, ok, maybe I can create a menu button to an external link and have that go to index.php in my domain root. This does work, sort of, but I get tons of "Strict Standards" errors at the top of the page whenever I visit that link. Also, when I go to that link, the menu item isn't highlighted, the highlighting remains on the forum menu item.

There are also bugs in the menu editor admin interface. For example, when I add a menu item and let's say I select "Internal Action" from the Type dropdown - the drop down for selecting the internal action doesn't appear. I can click the "Modify Button" command at the bottom of the page, then it will give me an error because of course Internal Action wasn't specified, and when the page reloads then the internal actions list will appear - but only sometimes, and sometimes not. The same behavior is observed with the other dynamic show/hide elements of a similar nature. I've tried two browsers (Chrome 45.0.2454.99 and Firefox 40.0.3) and both have Java enabled and seem to work fine in other respects.



Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on September 28, 2015, 04:03:06 pm
A friendly bump.

I'd hate to think SMFHacks is still charging people for a mod that isn't being maintained or supported, but some of the issues I am seeing were brought up in this forum over two years ago.

I'm hoping these turn out to be simple fixes rather than something approaching a scam. But the silence here is not a good sign. 
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: SMFHacks on September 28, 2015, 04:08:29 pm
Please pm Labradoodle-360
http://www.smfhacks.com/index.php?action=profile;u=10606
It is a third party mod made by a friend of mine.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on September 28, 2015, 06:18:12 pm
I'll look into this for you here shortly. What other modifications do you have installed? There seem to be a lot of jQuery conflicts with other mods.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on September 29, 2015, 11:38:53 am
Aside from Simple Portal, I'm using Ohara YouTube Embed (http://custom.simplemachines.org/mods/index.php?mod=3268), Highslide Image Viewer (http://custom.simplemachines.org/mods/index.php?mod=1450), and Custom View of Attachments (http://www.simplemachines.org/community/index.php?topic=418177.0).

However I just uninstalled all of them and it makes no difference. I will leave them uninstalled for now if it helps you test.

For what it's worth, the very first mod I installed after Simple Portal was Menu Editor Lite, so there would have been no other conflicts. It had pretty much the same problems as I'm seeing now with the Pro version. I assumed Lite was no longer supported which is why I purchased Pro, but I guess the issues are deeper than that.

The theme I'm running is Redsy by SMF Tricks (http://custom.simplemachines.org/themes/index.php?lemma=2833). I don't know if that could be a conflict as well or not.

PHP version is 5.4. Hosting is GoDaddy shared.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on September 29, 2015, 12:03:05 pm
I don't appreciate the snide comments about lack of support.

I assume you completely uninstalled Menu Editor Lite, right? And checked the box to remove all data associated with the mod?

I'm releasing a huge update to this mod as soon as SMF 2.1 is released in RC or stable. It'll be smart enough to import or delete Lite data while installing pro. Hopefully I can also clear up issues with the built-in caching system I wrote. Also since 2.1 has jQuery, all jQuery will work correctly.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on September 29, 2015, 12:17:19 pm
Yes, I completely uninstalled/deleted Lite. It doesn't even show in the Package Manager list anymore.

Although an update to coincide with a future SMF 2.1 will be great, I really need to get this working with the existing forum version.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on October 02, 2015, 03:56:03 pm
Is there anything else I can do to help you with this?
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 02, 2015, 04:03:00 pm
Send me a link to your forum, along with admin login details in a PM. FTP would also be helpful.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on October 02, 2015, 10:06:59 pm
PM sent.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 05, 2015, 07:38:03 pm
Looking into this now for you. Thanks for the patience.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 05, 2015, 08:19:46 pm
Okay, I have discovered the issues with the expanding and collapsing of permissions and membergroups is a conflict with your custom theme.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 05, 2015, 08:58:18 pm
I was also able to look at your error logs, and find an error in Menu Editor Pro (minor, not breaking anything, just PHP strict) that I resolved on your website, and recorded for the next patch.

Can't replicate your issue that you're having with your portal to me, it looks like SimplePortal isn't even being standalone when it's set to it.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on October 05, 2015, 09:02:42 pm
Okay, I have discovered the issues with the expanding and collapsing of permissions and membergroups is a conflict with your custom theme.
Ok - anything that can be done about that? Maybe just keep the options visible all the time instead?

If not, it's probably not a deal-breaker since as I say, with the correct sequence of clicks and curses I can often get the menus to appear. The main thing is to get Simple Portal to play nice.

Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 05, 2015, 09:12:19 pm
If you read my last few posts, I fixed all of the issues that your theme were causing. I can't replicate the SimplePortal issue on your site.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on October 05, 2015, 09:22:07 pm
Ok, I thought you had just "discovered" the issue, not necessarily fixed it. I see that the expanding/collapsing options are now working, that's great. Thanks for doing that.

As for the PHP strict stuff, I still see a bunch of error messages on the index page (My Home 2 in the menu). Of course, My Home 2 was just a plan B to work around the primary issue...

Which is Simple Portal - what is it that you're trying to replicate, and can't? The fact that Menu Editor Pro won't let me activate a menu internal action to Portal Home is the issue. Prior to installing MEP, Simple Portal was set to Standalone mode and the Standalone URL set to my index.php page in the root of my site (Simple Portal is still set to those settings). A "Home" and "Forum" button appeared on my menu, and they worked as expected.

After installing Menu Editor Pro that functionality broke - Menu Editor Pro will not permit the creation of a menu item set to Portal Home. It will let me create a menu item to an external link, but then when you go to that link, it shows the PHP strict errors...
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 06, 2015, 12:05:38 pm
Nope, I fixed them for you. Can you send me a screenshot of those errors? I didn't see them when I was working on it for you.

I don't even see that SimplePortal is in Standalone mode in the first place. If it were, the menu item would likely show up, but even though it says it's in Standalone mode in the portal settings, it doesn't appear to me that it is?
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on October 06, 2015, 12:19:50 pm
Here is a screenshot of the strict standards messages I get on index.php.

Regarding Simple Portal, you say "If it were [in Standalone mode], the menu item would likely show up." The menu item does show up, as you can see in the second screenshot. You can see this when you edit the My Home button in Menu Editor. The menu item for internal-action -> Simple Portal Home shows up and is selected. The issue is that Menu Editor will not let me activate that button.

If you still think this is a problem with Simple Portal, can you give me some specific, technical details about the statement that "Simple Portal does not appear to be in standalone mode"? Basically I need something that I can take to the Simple Portal forum and have them look at the error.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on October 06, 2015, 12:21:16 pm
I attached the images but for some reason they get stripped when I post. Maybe we have to have a minimum number of posts before we can attach?

I will try them again here... Nope, still doesn't work.

If you PM me an email I will send them to you that way.

In the case of the strict standards, this is the actual text that appears:
Code: [Select]
Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 132

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 132

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 169

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 169

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 169

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 169

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 169

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 169

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 169

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 169

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 169

Strict Standards: Only variables should be passed by reference in /home/mysite/public_html/forum/Sources/menu-editor-pro/resources/integrate.php on line 169
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 06, 2015, 02:52:13 pm
They got uploaded, might have just been a slight delay. Gotcha, I can fix that error for you.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 06, 2015, 03:16:44 pm
Hello Luke,

I just wanted to let you know that I fixed the bug in the code on your site, and then also set it up for you how I believe that you want it.

Best Regards
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on October 06, 2015, 03:47:39 pm
Holy moly, that is absolutely precisely how I want it. I'm not entirely sure how you did it, I see Simple Portal is set to "Front Page" rather than standalone, but index.php (at the root) is set to Standalone.

Is there anything I need to keep in mind as I'm editing and adding stuff? The strange thing is that if I go to mysite/index.php I am on a slightly different page than what I get to if I click on "Home", which takes me to mysite/forum/index.php. However they both end up with the same content so I guess it doesn't matter!

The only other glitch that I will bring to your attention, but which I don't need fixed, is that I believe sometimes MEP will give a brief notification message at the top of the page. For example, if I add a button to the menu a green line will expand slightly at the top of the page and then after a moment disappear. I'm assuming there is some kind of confirmation message that is supposed to appear there, but for me it isn't visible. No doubt it is a similar issue to the expanding/collapsing options. I don't personally need this fixed, you've done enough for me already. It's probably just a conflict with my particular theme. I only mention it in case it is a global conflict you want to address in your next release.

Thank you very much for the personalized support, it is greatly appreciated. I rescind my earlier skepticism and will definitely look forward to an SMF 2.1 version.

Thanks again. I'm now going to take a backup of the entire site!
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 06, 2015, 03:50:02 pm
Hey Luke,

You're very welcome for the help, it's nice to see everything working for you smoothly. I would recommend using SimplePortal with the homepage (not standalone), and then moving your forum from /forum to the root of your website. Menu Editor Pro will work best that way, and it looks like that might be exactly what you're looking for anyway.

Yeah, the notification at the top just let's you know that the action was completed, with a specified success message. It's again an issue related to your theme, but I appreciate your pointing it out.

Best Regards
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on October 06, 2015, 04:40:35 pm
Ha, I don't dare breathe on it now, let alone move the entire thing! :D Actually, I stuck the forum in its own folder for a reason -  the site is more than just a forum, we have a wiki, a web-shop, etc... None of those other applications integrate with SMF so I am putting everything into its own folder (site) to avoid conflicts.

But it's working now so all's well that ends well. Thanks again.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on October 06, 2015, 09:58:29 pm
Sorry to mention another issue... When I am on the forum homepage the "Forum" menu item is highlighted, as it should be. But as soon as I enter any board page or thread, the highlighting reverts to the "Home" menu item, although it should remain on "Forum."

Could you take a look at your convenience?

I'm attaching another screen shot. I can't actually see my own attachments but I'm assuming you can.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 07, 2015, 11:39:48 am
Hey there Luke,

Thanks for reporting that. It does indeed appear to be a slight oversight on my part in terms of the code, I'm not sure I'll be able to push a fix for you immediately on that one, but I logged it in my issues for the next version, and am considering pushing out a patch shortly with some common bugfixes.

Best Regards,
Matthew P. Kerle
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on October 07, 2015, 11:55:59 am
Great, thanks. A patch would be great, I'll keep my eyes open for one. I can live with it for now.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on October 07, 2015, 12:04:00 pm
What's in the line-up for the patch: http://prntscr.com/8osmm7
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on March 12, 2016, 12:24:49 pm
Sorry to mention another issue... When I am on the forum homepage the "Forum" menu item is highlighted, as it should be. But as soon as I enter any board page or thread, the highlighting reverts to the "Home" menu item, although it should remain on "Forum."

Sorry to revive this thread, but our site is going live shortly and I really need this last bug fixed. In addition to the behavior mentioned above, there is actually another probably-related bug.

In Menu Editor Pro I created a new tab called "Downloads." This points to a portal page that I created. When I visit the Downloads page, both the "Home" and "Downloads" tabs are highlighted along the top. This looks really bad.

I'm posting a screenshot which as usual I actually can't see myself. I will also send you a PM with an admin login that you can use to access the forum.

Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on March 19, 2016, 08:12:21 pm
Apologies again, but this is the one-week friendly nudge.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on March 25, 2016, 01:20:31 pm
Hey Luke,

Sorry for the late reply here. Do you by chance use Pretty URLs or anything of that nature? That honestly shouldn't affect it, but it's possible. Also, any errors related to Menu Editor Pro in the error log?

Best Regards,
Matthew
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on March 25, 2016, 01:41:44 pm
I'm not using Pretty URLs or any mod similar to it, in fact I have very few mods installed at all, mostly related to images and a YouTube viewer. The two big ones are Menu Editor Pro and Simple Portal.

There are no MEP errors in the error log.

I PM'd you an admin login to my forum so you can examine it for yourself, let me know if you need me to resend those credentials.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on March 31, 2016, 04:13:04 pm
I hate to keep pestering, but can you please take a look at this issue?
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on April 08, 2016, 09:32:49 pm
I'll put this on my calendar for this weekend.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on April 08, 2016, 10:33:29 pm
Thanks so very much. Please let me know if there is anything I can do to help troubleshoot or test, I will be around.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on April 15, 2016, 04:31:50 pm
Hi Matthew, I didn't see anything last weekend, that's ok, but please consider taking a stab at this perhaps this weekend! It would be great to get this resolved.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on April 19, 2016, 10:45:20 pm
Matthew, I hate to keep pestering you but I really have no other choice. Please make some time to address these issues, and please let me know any way in which I can help you.

Sincerely,

Luke
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on April 28, 2016, 12:34:18 pm
Sending you a PM.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: LukeZ on April 28, 2016, 02:54:25 pm
Just wanted to say Matthew got this fixed, and Menu Editor Pro now has no issues with Simple Portal, everything works as expected. 

Again, thanks so much for your help.
Title: Re: Menu Editor Pro with Simple Portal Home Page
Post by: Labradoodle-360 on April 28, 2016, 02:55:16 pm
You're welcome Luke. Sorry it took so incredibly long. I'll be pushing out this bugfix along with the next release to increase compatibility with SimplePortal.