ST Shop integration

[davejo]

Hi VB,

I have installed Diego's 'ST Shop' on my site. Using your Downloads mod when a member creates a download, and then clicks 'Add Download', I have it set that a topic is created in a board.

If a member posts directly into that board they get credits, in the ST Shop mod, for the new topic they've created. When they create a download and it creates a new topic in the board the topic that's created does not give them credits in the ST Shop even though it has their name as the topic starter.

Any idea why that might be?

Diego's mod is here https://custom.simplemachines.org/index.php?mod=1794

I'm using the ST Shop mod instead of yours as it also gives credits for members playing games in SMFArcade, as well as other things.

As always any help is much appreciated

See the settings page attached.

[SMFHacks]

ST Shop was not supported but added it now
6.2.1
+Added ST Shop support!

[davejo]

ST Shop was not supported but added it now
6.2.1
+Added ST Shop support!

Wow VB thank you very much

[davejo]

Sorry for seeming dumb , how do downloads work with the St Shop mod VB?

[SMFHacks]

These are the settings for SMF Shop/ ST Shop in the Admin Download settings
Shop Points Settings

Use SMF Shop money as credits instead of download system credits
Download Add Points:    
Comment Add Points:    


Options to add points if a download is added or if a comment is added to a download.
And the option to use shop money instead of download credit system.

[davejo]

Thank you VB

[davejo]

Houston we have a problem.

I set the Downloads Shop to enabled, see attached, and when a download is added it produces an error as attached.

Should the Downloads be installed first then the shop or doesn't it matter?

UPDATE: Just installed Downloads 6.2.1 and then ST Shop on a clean SMF 2.1.4 but the error still happens

[SMFHacks]

Did you have SMF Shop installed before?

If so delete the variable shopVersion from smf_settings table shopVersion

[davejo]

I found out what the issue was. I did a clean install of both the Downloads and Shop on my other site and it all works fine.

On my main site the reason I was getting the error is because in the 'Credit System' I had 'Credits added per upload' 1, thinking that while the 'Enable Credit System' was disabled the numbers would make no difference, but it does, because as soon as I set 'Credits added per upload' to 0 everything works fine.

I'm posting this so others can see what the error was. Should that happen if the Credit System is not enabled?

[Senkusha]

This may seem like a dumb question, but do I have to uninstall Downloads Pro 6.2 before installing 6.2.1?

[SMFHacks]

Though the package manager? Are you getting an error?

But for a minor release if I don't mention it you don't have to uninstall old version can just install on top.

[Senkusha]

Nope.  Thanks!  I didn't even notice the option was Upgrade, not Install.  It's been a long day.

[Senkusha]

Did you have SMF Shop installed before?

If so delete the variable shopVersion from smf_settings table shopVersion

I've never had SMF Shop installed on this forum, but I'm still getting this error, when enabling SMF Shop, even after updating to 6.2.1

Is there another place somewhere that I'm not seeing to use ST Shop instead?

[SMFHacks]

No it only looks for that variable here is the code that decides which one to use.

Code: [Select]

// Update the SMF Shop Points
if (isset($modSettings['shopVersion']))
  $smcFunc['db_query']('', "UPDATE {db_prefix}members
SET money = money + " . $modSettings['down_shop_fileadd'] . "
WHERE ID_MEMBER = " . $user_info['id'] . "
LIMIT 1");

if (isset($modSettings['Shop_importer_success']))
$smcFunc['db_query']('', "UPDATE {db_prefix}members
SET shopMoney = shopMoney + " . $modSettings['down_shop_fileadd'] . "
WHERE id_member = " . $user_info['id']. "
LIMIT 1");



[Senkusha]

[ Guests cannot view attachments ]

Okay.  I think I see the problem.  When I create a new topic/reply I get this:

[ Guests cannot view attachments ]

When I look at the code, I see this:

Code: [Select]

function Downloads_AddMemberCredits($memberID, $filesize, $credits = 0)
{
global $smcFunc, $downloadSettings;

if ($credits != 0)
{
$extraSMFShop = '';

if ($downloadSettings['down_set_intergrate_smfshop_money'])
$extraSMFShop = ', money = money +  ' . $credits. " ";

$smcFunc['db_query']('', "
UPDATE {db_prefix}members
SET downpro_credits = downpro_credits + " . $credits . "
$extraSMFShop
WHERE ID_MEMBER = $memberID LIMIT 1");
return;
}


And there's other checks a bit further down that use the database field money as well.  Shouldn't this be updated to use the same logic as above for full ST Shop support?