SQL Syntax Error Help?!

[Miyagi]

Hi,

Not the best SQL coder so really struggling to troubleshoot this.

Error:

Code: [Select]

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'condition, value1, value2, ID_CONDITION
FROM smf_store_shippingconditions' at line 2
File: /home/fordxrtu/public_html/forum/Sources/Store.php
Line: 5524
Code:

Code: [Select]

5521:    $result = db_query("
5522:    SELECT
5523:    percent, totalamount, condition, value1, value2, ID_CONDITION
5524:    FROM {$db_prefix}store_shippingconditions", __FILE__, __LINE__);
SQL Version on my server: 5.0.51a-community

Thoughts on how to fix?

Thanks,
Miyagi

[Miyagi]

2 seconds later... i think i've fixed it... the problem is condition is now a reserved word and needs to be 'condition'... can this be fixed properly in a new release to avoid future conflicts?

[SMFHacks]

Yes it can be you can escape it with `condition` the back ticks should allow it to work.

[Miyagi]

Still having intermittent issues with this error popping up across various parts of the shipping conditions so i dug deeper.

I'd suggest updating Store.Template.php in the package as follows:

REPLACE ON LINE 5669:

Code: [Select]

percent, totalamount, condition, value1, value2, ID_CONDITION

THIS:

Code: [Select]

percent, totalamount, 'condition', value1, value2, ID_CONDITION

Will help other members running store fix any potential issues.

[SMFHacks]

Fixed that issue for SMF Store 1.3