No E-Mail for Seller...

[Darkshadow]

If the auto accept with auto delete option is set, the seller will not receive a final e-mail with the info who buyed his ad, only a message that a bid was made.

It is verry helping when a final mail will send with info which member and what price are finaly happend to the ad.

Because it is impossible to list the ad in the bid history since it is auto deleted and the seller have no list manage rights... He never can see this infos anymore...

It is not a good workflow if he has to check all mails or pms to check who have won the auction. When he have multiple ads, its really frustrating to do so...

Its not a bug, but a missing funktion...

I have implemented a mail send for the buyer, but i cant insert a mail for the seller, please lock my attached classified.php file (funktion CheckForExpiredListings) i added a else to do so...

I also have implemented some improvements:

No autoaccept occurs if reserve price not met, send the buyer a mail -> bid to low
Not allowed the option to add more days anymore,  if a bid is made for that listing
Inserted a back to listing link in option section
Listing is green color if more than 24 h
Listing is yellow color if less 24 h but more than 5 min
Listing is red color if less 5 min


i will be really happy if you can it insert in the official updates, so i can sure everything is fine...


Annother big error is following:

If option private bid is possible for a category, it is unable for the seller to see who has made a bid for his listing, if the buyer used private bid option, so members can do joke bids and the seller have no chance to get this members.
It is a must option for the seller to see what members have placed a bid, all time...
If private bid is used, only other members dont see the buyer...

The seller cant contact the buyer because its unknown ?



Darkshadow

[SMFHacks]

1.2.24
+Email now sent to the seller if the bid is auto accepted
!Fix display of private bids to the listing owner on the view bids page
!Do not auto accept bid if reserve price is greater than the bid amount

[Darkshadow]

In "function AcceptBidByID($id, $autoAccept = false)", there is a bug...

Fatal error: Function name must be a string /Sources/classifieds.php on line 6963

the error occurs if classifieds try to send the new mail to seller


Status:
-----------

+Email now sent to the seller if the bid is auto accepted                       <--------------- Not working
!Fix display of private bids to the listing owner on the view bids page      <--------------- i currently check this
!Do not auto accept bid if reserve price is greater than the bid amount   <--------------- i currently check this


Status 2:
-------------

+Email now sent to the seller if the bid is auto accepted                       <--------------- working only partly with a little fix
!Fix display of private bids to the listing owner on the view bids page      <--------------- working
!Do not auto accept bid if reserve price is greater than the bid amount   <--------------- will check this

Little Fix
------------

Original Code: $pm_title = $smcFunc['db_escape_string']($row['title'] . $txt['class_text_listing_completed']);

Modified Code: $pm_title = $row['title'] . $txt['class_text_listing_completed'];

But the link created inside the mail (to the buyers profile) will not work... builds an wrong url...


Status 3:
-------------

+Email now sent to the seller if the bid is auto accepted                       <--------------- seems to working with this two little fixes
!Fix display of private bids to the listing owner on the view bids page      <--------------- working
!Do not auto accept bid if reserve price is greater than the bid amount   <--------------- will check this

Little Fix 1
--------------

Original Code: $pm_title = $smcFunc['db_escape_string']($row['title'] . $txt['class_text_listing_completed']);

Modified Code: $pm_title = $row['title'] . $txt['class_text_listing_completed'];


Little Fix 2
--------------

Original Code:

Code: [Select]

$accepted_body .= "[url=' . $scripturl . '?action=profile;u=" . $row['BIDMEMBER'] . "]" . $row['realName']. "[/url] " . $txt['class_text_listing_completed2']  . $row['amount'] ;
Modified Code:

Code: [Select]

$accepted_body .= "[url=" . $scripturl . '?action=profile;u=' . $row['BIDMEMBER'] . "]" . $row['realName']. "[/url] " . $txt['class_text_listing_completed2']  . $row['amount']. $txt['class_text_listing_completed3'] ;
I added an extra string for some texts like the "EUR" sign... ($txt['class_text_listing_completed3'] ) the german sentence are more complicated and need more customizable strings...


Thanks for your fast reply this time...

Maybe you implement my color change code and mail (if bid was to low (reserve price not met)) to last bid member if auction was ended, in your official update ?

Darkshadow

[SMFHacks]

Not sure about the colors yet kind of would depend on theme that was used could look odd for some.

1.2.25
!Fix bug on autoaccept bid for SMF 1.1.X for sending email to seller
+Added failed win pm on autoaccept if the bid did not meet the reserve price

[Darkshadow]

Ok, now it works.

Thanks...



Darkshadow