Facebook  Twitter 

SMFHacks.com

+- +-

SMFHacks.com

+- User Information

Welcome, Guest.
Please login or register.
 
 
 
Forgot your password?

+- Forum Stats

Members
Total Members: 12399
Latest: tssycnlys01
New This Month: 5
New This Week: 0
New Today: 0
Stats
Total Posts: 39914
Total Topics: 7026
Most Online Today: 65
Most Online Ever: 2482
(April 09, 2011, 07:02:45 pm)
Users Online
Members: 1
Guests: 35
Total: 36

Author Topic: No E-Mail for Seller...  (Read 5935 times)

0 Members and 1 Guest are viewing this topic.

Offline Darkshadow

  • Jr. Member
  • **
  • Posts: 65
    • View Profile
    • Dark Mysterious Worlds
No E-Mail for Seller...
« on: June 01, 2009, 01:56:24 am »
If the auto accept with auto delete option is set, the seller will not receive a final e-mail with the info who buyed his ad, only a message that a bid was made.

It is verry helping when a final mail will send with info which member and what price are finaly happend to the ad.

Because it is impossible to list the ad in the bid history since it is auto deleted and the seller have no list manage rights... He never can see this infos anymore...

It is not a good workflow if he has to check all mails or pms to check who have won the auction. When he have multiple ads, its really frustrating to do so...

Its not a bug, but a missing funktion...

I have implemented a mail send for the buyer, but i cant insert a mail for the seller, please lock my attached classified.php file (funktion CheckForExpiredListings) i added a else to do so...

I also have implemented some improvements:

No autoaccept occurs if reserve price not met, send the buyer a mail -> bid to low
Not allowed the option to add more days anymore,  if a bid is made for that listing
Inserted a back to listing link in option section
Listing is green color if more than 24 h
Listing is yellow color if less 24 h but more than 5 min
Listing is red color if less 5 min


i will be really happy if you can it insert in the official updates, so i can sure everything is fine...


Annother big error is following:

If option private bid is possible for a category, it is unable for the seller to see who has made a bid for his listing, if the buyer used private bid option, so members can do joke bids and the seller have no chance to get this members.
It is a must option for the seller to see what members have placed a bid, all time...
If private bid is used, only other members dont see the buyer...

The seller cant contact the buyer because its unknown ???????



Darkshadow
« Last Edit: June 01, 2009, 03:05:35 am by Darkshadow »

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 14965
    • View Profile
Re: No E-Mail for Seller...
« Reply #1 on: June 01, 2009, 09:00:45 pm »
1.2.24
+Email now sent to the seller if the bid is auto accepted
!Fix display of private bids to the listing owner on the view bids page
!Do not auto accept bid if reserve price is greater than the bid amount
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline Darkshadow

  • Jr. Member
  • **
  • Posts: 65
    • View Profile
    • Dark Mysterious Worlds
Re: No E-Mail for Seller...
« Reply #2 on: June 02, 2009, 08:12:08 am »
In "function AcceptBidByID($id, $autoAccept = false)", there is a bug...

Fatal error: Function name must be a string /Sources/classifieds.php on line 6963

the error occurs if classifieds try to send the new mail to seller


Status:
-----------

+Email now sent to the seller if the bid is auto accepted                       <--------------- Not working
!Fix display of private bids to the listing owner on the view bids page      <--------------- i currently check this
!Do not auto accept bid if reserve price is greater than the bid amount   <--------------- i currently check this


Status 2:
-------------

+Email now sent to the seller if the bid is auto accepted                       <--------------- working only partly with a little fix
!Fix display of private bids to the listing owner on the view bids page      <--------------- working
!Do not auto accept bid if reserve price is greater than the bid amount   <--------------- will check this

Little Fix
------------

Original Code: $pm_title = $smcFunc['db_escape_string']($row['title'] . $txt['class_text_listing_completed']);

Modified Code: $pm_title = $row['title'] . $txt['class_text_listing_completed'];

But the link created inside the mail (to the buyers profile) will not work... builds an wrong url...


Status 3:
-------------

+Email now sent to the seller if the bid is auto accepted                       <--------------- seems to working with this two little fixes
!Fix display of private bids to the listing owner on the view bids page      <--------------- working
!Do not auto accept bid if reserve price is greater than the bid amount   <--------------- will check this

Little Fix 1
--------------

Original Code: $pm_title = $smcFunc['db_escape_string']($row['title'] . $txt['class_text_listing_completed']);

Modified Code: $pm_title = $row['title'] . $txt['class_text_listing_completed'];


Little Fix 2
--------------

Original Code:

Code: [Select]
$accepted_body .= "[url=' . $scripturl . '?action=profile;u=" . $row['BIDMEMBER'] . "]" . $row['realName']. "[/url] " . $txt['class_text_listing_completed2']  . $row['amount'] ;
Modified Code:
Code: [Select]
$accepted_body .= "[url=" . $scripturl . '?action=profile;u=' . $row['BIDMEMBER'] . "]" . $row['realName']. "[/url] " . $txt['class_text_listing_completed2']  . $row['amount']. $txt['class_text_listing_completed3'] ;
I added an extra string for some texts like the "EUR" sign... ($txt['class_text_listing_completed3'] ) the german sentence are more complicated and need more customizable strings...


Thanks for your fast reply this time...

Maybe you implement my color change code and mail (if bid was to low (reserve price not met)) to last bid member if auction was ended, in your official update ?

Darkshadow

« Last Edit: June 02, 2009, 02:34:21 pm by Darkshadow »

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 14965
    • View Profile
Re: No E-Mail for Seller...
« Reply #3 on: June 02, 2009, 08:52:39 pm »
Not sure about the colors yet kind of would depend on theme that was used could look odd for some.

1.2.25
!Fix bug on autoaccept bid for SMF 1.1.X for sending email to seller
+Added failed win pm on autoaccept if the bid did not meet the reserve price
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline Darkshadow

  • Jr. Member
  • **
  • Posts: 65
    • View Profile
    • Dark Mysterious Worlds
Re: No E-Mail for Seller...
« Reply #4 on: June 04, 2009, 01:54:58 pm »
Ok, now it works.

Thanks...



Darkshadow

 

Related Topics

  Subject / Started by Replies Last post
1 Replies
3294 Views
Last post April 03, 2009, 07:58:53 am
by Sweetwater
5 Replies
3832 Views
Last post July 13, 2009, 10:44:30 pm
by SMFHacks
0 Replies
1827 Views
Last post May 28, 2011, 04:26:38 am
by Elvp
3 Replies
3843 Views
Last post August 01, 2013, 09:31:56 am
by SMFHacks
1 Replies
2311 Views
Last post October 14, 2013, 07:50:38 am
by rogerrabbit332

+- Recent Topics

PHP error by SMFHacks
Today at 03:55:24 pm

Message Editor Pro Issues by SMFHacks
November 06, 2019, 09:58:33 pm

most popular categories doesnt work by fussilet
November 02, 2019, 02:51:42 pm

Change colors of Halloween theme by SMFHacks
October 24, 2019, 11:44:59 am

prettyurls - TroubleShooting.wiki by Rock Lee
October 10, 2019, 11:37:09 am

Some issues with adding and editing a listing by ajac63
October 07, 2019, 04:16:40 am

Problem update 1.1.21 to 2.0.15 by Rock Lee
October 06, 2019, 06:09:16 pm

[Mod]SMF 2.0.x PHP 7.2 Support by sah62
October 04, 2019, 01:46:00 pm

Ideas by shuban
October 03, 2019, 10:19:06 pm

How to space icons and multiple reacts? by shadav
October 03, 2019, 04:20:07 pm

Powered by EzPortal