Just some minor code errors and fixes for Gallery Pro 2.5

[treasurenet]

1. lightbox not working.
Cause: incorrect url to lightbox javascript files.

Fix....

In Gallery2.php  find....

Code: [Select]

// Using Lighbox
if ($modSettings['gallery_set_nohighslide'] == 2)
$context['html_headers'] .= '<script type="text/javascript" src="' . $modSettings['gallery_path'] . 'js/prototype.js"></script>
<script type="text/javascript" src="' . $modSettings['gallery_path'] . 'js/scriptaculous.js?load=effects"></script>
<script type="text/javascript" src="' . $modSettings['gallery_path'] . 'js/lightbox.js"></script>
<link rel="stylesheet" href="' . $modSettings['gallery_path'] . 'css/lightbox.css" type="text/css" media="screen" />';
   
Replace with....

Code: [Select]

// Using Lighbox
if ($modSettings['gallery_set_nohighslide'] == 2)
$context['html_headers'] .= '<script type="text/javascript" src="' . $modSettings['gallery_url'] . 'js/prototype.js"></script>
<script type="text/javascript" src="' . $modSettings['gallery_url'] . 'js/scriptaculous.js?load=effects"></script>
<script type="text/javascript" src="' . $modSettings['gallery_url'] . 'js/lightbox.js"></script>
<link rel="stylesheet" href="' . $modSettings['gallery_url'] . 'css/lightbox.css" type="text/css" media="screen" />';
   
      

In Gallery.php  find....   
      

Code: [Select]

// Using Lighbox
if ($modSettings['gallery_set_nohighslide'] == 2)
$context['html_headers'] .= '<script type="text/javascript" src="' . $modSettings['gallery_path'] . 'js/prototype.js"></script>
<script type="text/javascript" src="' . $modSettings['gallery_path'] . 'js/scriptaculous.js?load=effects"></script>
<script type="text/javascript" src="' . $modSettings['gallery_path'] . 'js/lightbox.js"></script>
<link rel="stylesheet" href="' . $modSettings['gallery_path']. 'css/lightbox.css" type="text/css" media="screen" />';
Replace with....

Code: [Select]

// Using Lighbox
if ($modSettings['gallery_set_nohighslide'] == 2)
$context['html_headers'] .= '<script type="text/javascript" src="' . $modSettings['gallery_url'] . 'js/prototype.js"></script>
<script type="text/javascript" src="' . $modSettings['gallery_url'] . 'js/scriptaculous.js?load=effects"></script>
<script type="text/javascript" src="' . $modSettings['gallery_url'] . 'js/lightbox.js"></script>
<link rel="stylesheet" href="' . $modSettings['gallery_url']. 'css/lightbox.css" type="text/css" media="screen" />';
2. invalid html code
align=top" should be valign="top"

Fix...

Go to line 1490 of Gallery.template.php

find...

Code: [Select]

'?action=profile;u=' . $context['gallery_pic']['ID_MEMBER'] . '">'  . $context['gallery_pic']['realName'] . '</a><a href="', $scripturl, '?action=gallery;sa=myimages;u=' . $context['gallery_pic']['ID_MEMBER'] . '"><img src="'.$settings['images_url'].'/filter.gif" align=top" style="margin: 0 1ex;" alt="" /></a>&nbsp;';
replace with....

Code: [Select]

'?action=profile;u=' . $context['gallery_pic']['ID_MEMBER'] . '">'  . $context['gallery_pic']['realName'] . '</a><a href="', $scripturl, '?action=gallery;sa=myimages;u=' . $context['gallery_pic']['ID_MEMBER'] . '"><img src="'.$settings['images_url'].'/filter.gif" valign="top" style="margin: 0 1ex;" alt="" /></a>&nbsp;';
3. invalid html code....
closing tag for input form missing.....

Fix - go to line 1876 of Gallery.template.php

find....

Code: [Select]

if ($modSettings['gallery_set_showcode_bbc_image'])
echo '<tr><td width="30%">', $txt['gallery_txt_bbcimage'], '</td><td> <input type="text" value="[img]' . $modSettings['gallery_url'] . $context['gallery_pic']['filename']  . '[/img]" size="50"></td></tr>';

if ($modSettings['gallery_set_showcode_directlink'])
echo '<tr><td width="30%">', $txt['gallery_txt_directlink'], '</td><td> <input type="text" value="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename']  . '" size="50"></td></tr>';

if ($modSettings['gallery_set_showcode_htmllink'])
echo '<tr><td width="30%">', $txt['gallery_set_showcode_htmllink'], '</td><td> <input type="text" value="<img src=&#34;' . $modSettings['gallery_url'] . $context['gallery_pic']['filename']  . '&#34; />" size="50"></td></tr>';
replace with....

Code: [Select]

if ($modSettings['gallery_set_showcode_bbc_image'])
echo '<tr><td width="30%">', $txt['gallery_txt_bbcimage'], '</td><td> <input type="text" value="[img]' . $modSettings['gallery_url'] . $context['gallery_pic']['filename']  . '[/img]" size="50" /></td></tr>';

if ($modSettings['gallery_set_showcode_directlink'])
echo '<tr><td width="30%">', $txt['gallery_txt_directlink'], '</td><td> <input type="text" value="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename']  . '" size="50" /></td></tr>';

if ($modSettings['gallery_set_showcode_htmllink'])
echo '<tr><td width="30%">', $txt['gallery_set_showcode_htmllink'], '</td><td> <input type="text" value="<img src=&#34;' . $modSettings['gallery_url'] . $context['gallery_pic']['filename']  . '&#34; />" size="50" /></td></tr>';
4. Missing alt tags

There are several not mentioned here, but go to line 1372 in Gallery.template.php and find.....

Code: [Select]

if ($modSettings['gallery_make_medium'] == 0 || $context['gallery_pic']['mediumfilename'] == '')
echo '<img height="' . $context['gallery_pic']['height']  . '" width="' . $context['gallery_pic']['width']  . '" src="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename']  . '" />';
else
echo '<a href="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename'] . '"><img height="' . $context['gallery_pic']['height']  . '" width="' . $context['gallery_pic']['width']  . '" src="' . $modSettings['gallery_url'] . $context['gallery_pic']['mediumfilename']  . '" /></a>';
}
else if ($modSettings['gallery_set_nohighslide'] == 2)
{
// Lightbox
if ($modSettings['gallery_make_medium'] == 0 || $context['gallery_pic']['mediumfilename'] == '')
echo '<a href="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename'] . '" rel="lightbox" title="' . $context['gallery_pic']['description'] . '"><img height="' . $context['gallery_pic']['height']  . '" width="' . $context['gallery_pic']['width']  . '" src="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename']  . '" /></a>';
else
echo '<a href="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename'] . '" rel="lightbox" title="' . $context['gallery_pic']['description'] . '"><img height="' . $context['gallery_pic']['height']  . '" width="' . $context['gallery_pic']['width']  . '" src="' . $modSettings['gallery_url'] . $context['gallery_pic']['mediumfilename']  . '" /></a>';
and replace with....  

Code: [Select]

if ($modSettings['gallery_make_medium'] == 0 || $context['gallery_pic']['mediumfilename'] == '')
echo '<img height="' . $context['gallery_pic']['height']  . '" width="' . $context['gallery_pic']['width']  . '" src="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename']  . '" alt="" />';
else
echo '<a href="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename'] . '"><img height="' . $context['gallery_pic']['height']  . '" width="' . $context['gallery_pic']['width']  . '" src="' . $modSettings['gallery_url'] . $context['gallery_pic']['mediumfilename']  . '" alt="" /></a>';
}
else if ($modSettings['gallery_set_nohighslide'] == 2)
{
// Lightbox
if ($modSettings['gallery_make_medium'] == 0 || $context['gallery_pic']['mediumfilename'] == '')
echo '<a href="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename'] . '" rel="lightbox" title="' . $context['gallery_pic']['description'] . '"><img height="' . $context['gallery_pic']['height']  . '" width="' . $context['gallery_pic']['width']  . '" src="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename']  . '" alt="" /></a>';
else
echo '<a href="' . $modSettings['gallery_url'] . $context['gallery_pic']['filename'] . '" rel="lightbox" title="' . $context['gallery_pic']['description'] . '"><img height="' . $context['gallery_pic']['height']  . '" width="' . $context['gallery_pic']['width']  . '" src="' . $modSettings['gallery_url'] . $context['gallery_pic']['mediumfilename']  . '" alt="" /></a>';

[SMFHacks]

Fixed all for next release