SMG Gallery 2.5.4 and deleted photos error log messages

[guest3817]

Hi

I have SMF gallery 2.5.4 installed. I recently cleared out a lot of pictures from the gallery. Now I'm getting errors(in the error log0 such as the one below when the site is visited by webspiders.

Type of error: General
URL http://www.xxx.co.uk/forum/index.php?action=gallery;sa=view;id=230
No picture selected.

Is there any way to avod the generation of these errors or will they eventually stop happening when the spiders stop trying to visit these deleted items?

[SMFHacks]

Fixed for Gallery 2.5.5



Hotfix for SMF 1.1.x
Open Sources/Gallery.php
Around Line 891
Find

Code: [Select]

// Get the picture ID
$id = (int) $_REQUEST['id'];
if (empty($id))
fatal_error($txt['gallery_error_no_pic_selected']);

// Show top Tabs
TopButtonTabs();

$dbresult = db_query("
SELECT
ID_PICTURE, USER_ID_CAT, ID_CAT
FROM {$db_prefix}gallery_pic
WHERE ID_PICTURE = $id  LIMIT 1", __FILE__, __LINE__);
$row = mysql_fetch_assoc($dbresult);
if (mysql_num_rows($dbresult) == 0)
{
fatal_error($txt['gallery_error_no_pic_selected']);
}
Change to

Code: [Select]

// Get the picture ID
$id = (int) $_REQUEST['id'];
if (empty($id))
fatal_error($txt['gallery_error_no_pic_selected'],false);

// Show top Tabs
TopButtonTabs();

$dbresult = db_query("
SELECT
ID_PICTURE, USER_ID_CAT, ID_CAT
FROM {$db_prefix}gallery_pic
WHERE ID_PICTURE = $id  LIMIT 1", __FILE__, __LINE__);
$row = mysql_fetch_assoc($dbresult);
if (mysql_num_rows($dbresult) == 0)
{
fatal_error($txt['gallery_error_no_pic_selected'],false);
}



Fix for SMF 2.0

Open Sources/Gallery2.php
Around line 934
Find

Code: [Select]

// Get the picture ID
$id = (int) $_REQUEST['id'];
if (empty($id))
fatal_error($txt['gallery_error_no_pic_selected']);

// Show top Tabs
TopButtonTabs();

$dbresult = $smcFunc['db_query']('', "
SELECT
id_picture, user_id_cat, id_cat
FROM {db_prefix}gallery_pic
WHERE id_picture = $id  LIMIT 1");
$row = $smcFunc['db_fetch_assoc']($dbresult);
if ($smcFunc['db_num_rows']($dbresult) == 0)
{
fatal_error($txt['gallery_error_no_pic_selected']);
}
Change to

Code: [Select]

// Get the picture ID
$id = (int) $_REQUEST['id'];
if (empty($id))
fatal_error($txt['gallery_error_no_pic_selected'],false);

// Show top Tabs
TopButtonTabs();

$dbresult = $smcFunc['db_query']('', "
SELECT
id_picture, user_id_cat, id_cat
FROM {db_prefix}gallery_pic
WHERE id_picture = $id  LIMIT 1");
$row = $smcFunc['db_fetch_assoc']($dbresult);
if ($smcFunc['db_num_rows']($dbresult) == 0)
{
fatal_error($txt['gallery_error_no_pic_selected'],false);
}


[guest3817]

Excellent thanks. Worked a treat.

[guest3817]

Hi

back again I'm afraid. I'm also seeing errors like the following in the error log
caused by http://www.xxxx.co.uk/forum/index.php?action=gallery;sa=prev;id=162

"You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND p.user_id_cat = AND p.approved = 1 AND p.id_picture > 162

ORDER BY p.id_' at line 7
File: /home/xxxx/public_html/xxx/forum/Sources/Gallery2.php
Line: 10748 "

Which I think is also related to Spider accessing deleted photos . I didnt notice these before amongst the other error messages

There was also one occurence of this error message caused by the same spider at the same time the ORDER By p.id error was generated(from the error log)

" Type of error: General
http://www.xxxx.co.uk/forum/index.php?action=reporttm;topic=322.9;msg=1138

The board you specified doesn't exist"

I think this might have been a topic created by posting an image and that was subsequently deleted.

Any help would be greatly appreciated.

[guest3817]

Any ideas? Its not a big thing but I've been getting about 10 errors a day which I have to clear out.

[SMFHacks]

Will check it out either friday  and this weekend been sick for the last couple days

[guest3817]

OK no worries. Hope your feeling better.

[SMFHacks]

Fixed the error with next/previous links error in latest release.

2.5.5
!Fixed when viewing non existent pictures not to log an error
!Fixed database error for spiders following old previous/next links

[guest3817]

Excellent thanks again.