Facebook  Twitter 

SMFHacks.com

+-

SMFHacks.com

+- User Information

Welcome, Guest.
Please login or register.
 
 
 
Forgot your password?

+- Forum Stats

Members
Total Members: 11832
Latest: balasahu
New This Month: 7
New This Week: 1
New Today: 1
Stats
Total Posts: 42228
Total Topics: 7368
Most Online Today: 51
Most Online Ever: 2482
(April 09, 2011, 07:02:45 pm)
Users Online
Members: 0
Guests: 46
Total: 46

Author Topic: Ad Seller Pro breaks Remove Old Posts  (Read 3737 times)

0 Members and 1 Guest are viewing this topic.

Offline David8

  • Member
  • *
  • Posts: 18
    • View Profile
Ad Seller Pro breaks Remove Old Posts
« on: February 11, 2011, 11:23:03 am »
I am running an SMF 2.0 RC4 system and want to remove old posts from some of my boards.  I get the following error message: "Unable to verify referring url. Please go back and try again."

I have traced the problem to the appearance of an "action=adpro" in a 'old_url' that is tested by Security.php

Here is the thread I opened on the SMF support board.

http://www.simplemachines.org/community/index.php?topic=415940.0

I think that I have identified the source of the problem.  It seems that the
package Ad Seller Pro 1.0.8 is messing up the URL.

The error message is triggered by code in Security.php at lines 723 to 728 in
definition of function checkSession().  This function is called by function
RemoveOldTopics2() in RemoveTopics.php with the arguments shown:

   checkSession('post', 'admin');

At line 724 checkSession tests to see if the code 'action=admin' is present in
the URL returned by the PHP function $_SESSION['old_url'].  The test fails and
triggers the error 'verify_url_fail'.

To debug I inserted the following line of code after line 725 in Security.php

      log_error('old_url=[' . $_SESSION['old_url'] . ']');

This code returns the following in the error log:

http://...my board domain.../index.php?action=admin;area=maintain;sa=topics;activity=pruneold
old_url=[http://...my board domain.../index.php?action=adpro;sa=v&id=7&l=2&m=0&t=1297440989]

The second line above shows the problem.  It says 'action=adpro' not 'action=admin'
and the test fails.  It looks like Ad Seller Pro is messing up the old_url.

Now the question is how to fix it.

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 16003
    • View Profile
Re: Ad Seller Pro breaks Remove Old Posts
« Reply #1 on: February 11, 2011, 12:02:31 pm »
Try changing the following

Open Sources/Subs.php

Find
Code: [Select]
// Remember this URL in case someone doesn't like sending HTTP_REFERER.
if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false)
$_SESSION['old_url'] = $_SERVER['REQUEST_URL'];


Change to
Code: [Select]
// Remember this URL in case someone doesn't like sending HTTP_REFERER.
if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=adpro') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false)
$_SESSION['old_url'] = $_SERVER['REQUEST_URL'];

Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline David8

  • Member
  • *
  • Posts: 18
    • View Profile
Re: Ad Seller Pro breaks Remove Old Posts
« Reply #2 on: February 13, 2011, 04:54:26 pm »
Your hack fixed it.  Why did the problem occur?  Is Ad Seller Pro changing the old_url variable that SMF seems to rely on for verification? 

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 16003
    • View Profile
Re: Ad Seller Pro breaks Remove Old Posts
« Reply #3 on: February 13, 2011, 05:34:58 pm »
Will SMF logs all urls/actions so when a view occurs after the page is loaded that is the last url that is visited.

Will add the fix then update for RC5.
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

 

Related Topics

  Subject / Started by Replies Last post
0 Replies
2689 Views
Last post October 13, 2008, 08:44:54 am
by darkorical
6 Replies
7054 Views
Last post January 22, 2010, 04:26:17 pm
by SMFHacks
Ad Seller Pro

Started by bulldog71169 « 1 2 » Support

16 Replies
7225 Views
Last post December 30, 2010, 05:18:11 pm
by bulldog71169
1 Replies
2199 Views
Last post January 04, 2011, 10:14:04 pm
by SMFHacks
3 Replies
2272 Views
Last post March 12, 2017, 01:13:00 pm
by Darkshadow

+- Recent Topics

Dark background text color help needed by Shades
May 22, 2022, 04:51:25 pm

Database Error During Store Purchase After SMF 2.1 and Store 5.0 Beta Upgrades by Michael Vail
May 20, 2022, 08:58:15 pm

Default License Agreement by SMFHacks
May 18, 2022, 08:18:15 pm

Email Note - Included in order purchase by Shades
May 18, 2022, 02:54:54 pm

[Feature Request] Keywords by Shades
May 18, 2022, 02:20:19 pm

Undefined index: down_path by Shades
May 18, 2022, 10:19:09 am

Delete custom rating and change default icons/change icons back to default? by SMFHacks
May 18, 2022, 10:06:01 am

Thumbnails on topic page not resizing correctly by SMFHacks
May 14, 2022, 10:45:34 pm

Server Issues by PapaFrizArcade
May 12, 2022, 11:50:04 am

Funky Pagination by SMFHacks
May 11, 2022, 11:38:24 pm

Powered by EzPortal