Facebook  Twitter 

SMFHacks.com

+- +-

SMFHacks.com

+- User Information

Welcome, Guest.
Please login or register.
 
 
 
Forgot your password?

+- Forum Stats

Members
Total Members: 12370
Latest: laurieb
New This Month: 1
New This Week: 1
New Today: 0
Stats
Total Posts: 40210
Total Topics: 7081
Most Online Today: 105
Most Online Ever: 2482
(April 09, 2011, 07:02:45 pm)
Users Online
Members: 0
Guests: 45
Total: 45

Author Topic: Bypass Download Limit Bug  (Read 3960 times)

0 Members and 1 Guest are viewing this topic.

Offline elbeer

  • Downloads Pro Customer
  • Full Member
  • *****
  • Posts: 101
    • View Profile
Bypass Download Limit Bug
« on: March 15, 2015, 06:21:27 am »
This is quite a pain of a bug. If a user opens up a list of downloads e.g. from http://mydomain.com/index.php?action=downloads;cat=5

And say 10 downloads are listed. If they right click each page for the download and open them up in separate tabs they will have 10 pages open with 10 different downloads.

Even though I have a download limit per day set in admin - they can simply press download on each of the open tabs and gain access to each download bypassing any limits I have set.

I have locked down the template but there needs to be some sort of check from downloads2.php prior to releasing the download. e.g. on click of the link check the download count before going on to reveal the download.


Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 15105
    • View Profile
Re: Bypass Download Limit Bug
« Reply #1 on: March 18, 2015, 10:09:20 pm »
Quote

Even though I have a download limit per day set in admin - they can simply press download on each of the open tabs and gain access to each download bypassing any limits I have set.
I don't see how that is possible.... I looked at the code it calls the Downloads_DownloadFile file in Downloads2.php and that handles all the checks before the file can be downloaded.
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline elbeer

  • Downloads Pro Customer
  • Full Member
  • *****
  • Posts: 101
    • View Profile
Re: Bypass Download Limit Bug
« Reply #2 on: March 19, 2015, 03:17:04 am »
The checks are done when you open the download page. So if you open 20 download pages and dont actually download anything until all 20 tabs are open you can download as many files as you like.

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 15105
    • View Profile
Re: Bypass Download Limit Bug
« Reply #3 on: March 19, 2015, 08:05:45 am »
But you shouldn't be able to download the files though... You might be able to open the pages to view download page but not actually download the files.
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline elbeer

  • Downloads Pro Customer
  • Full Member
  • *****
  • Posts: 101
    • View Profile
Re: Bypass Download Limit Bug
« Reply #4 on: March 23, 2015, 10:17:09 am »
But you can. If you open the download page without actually clicking download the link is rendered but is not counted. If you open up multiple pages where the links are rendered you can then download each file without checking the amount of downloads.

 

Related Topics

  Subject / Started by Replies Last post
3 Replies
4579 Views
Last post February 08, 2008, 01:39:16 am
by rtyug
1 Replies
3663 Views
Last post February 07, 2008, 09:59:50 pm
by rtyug
3 Replies
4853 Views
Last post May 19, 2008, 08:30:12 pm
by ApplianceJunk
3 Replies
1918 Views
Last post December 09, 2010, 10:43:34 am
by SMFHacks
4 Replies
2171 Views
Last post February 02, 2013, 11:42:07 am
by amwebby

+- Recent Topics

Download System Lite by Rock Lee
June 03, 2020, 07:34:24 pm

Font question by SMFHacks
May 27, 2020, 08:15:26 am

Error message with latest SMF 2.1 Github build by Hatshepsut
May 25, 2020, 01:43:26 am

smfblog not working on 2.0.17 by tech9
May 20, 2020, 01:44:34 pm

Copyright removal by stbc
May 18, 2020, 01:27:57 am

Mod Verified User i can't square the image by Rock Lee
May 07, 2020, 07:56:10 pm

SMF4Mobile 2.0 released for SMF 2.0.x by SMFHacks
May 06, 2020, 12:13:14 pm

SMF Social Login Pro - Discontinued? by Nicole
May 02, 2020, 05:47:04 pm

Likes by SMFHacks
April 30, 2020, 09:50:35 pm

Upgrade Issue - by SMFHacks
April 28, 2020, 12:40:13 pm

Powered by EzPortal