Facebook  Twitter 

SMFHacks.com

+-

SMFHacks.com

+- User Information

Welcome, Guest.
Please login or register.
 
 
 
Forgot your password?

+- Forum Stats

Members
Total Members: 4255
Latest: andreios
New This Month: 3
New This Week: 1
New Today: 0
Stats
Total Posts: 43261
Total Topics: 7519
Most Online Today: 297
Most Online Ever: 2482
(April 09, 2011, 07:02:45 pm)
Users Online
Members: 0
Guests: 300
Total: 300

Author Topic: Bypass Download Limit Bug  (Read 6017 times)

0 Members and 1 Guest are viewing this topic.

Offline elbeer

  • Downloads Pro Customer
  • Full Member
  • *****
  • Posts: 111
    • View Profile
Bypass Download Limit Bug
« on: March 15, 2015, 06:21:27 am »
This is quite a pain of a bug. If a user opens up a list of downloads e.g. from http://mydomain.com/index.php?action=downloads;cat=5

And say 10 downloads are listed. If they right click each page for the download and open them up in separate tabs they will have 10 pages open with 10 different downloads.

Even though I have a download limit per day set in admin - they can simply press download on each of the open tabs and gain access to each download bypassing any limits I have set.

I have locked down the template but there needs to be some sort of check from downloads2.php prior to releasing the download. e.g. on click of the link check the download count before going on to reveal the download.


Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 16436
    • View Profile
Re: Bypass Download Limit Bug
« Reply #1 on: March 18, 2015, 10:09:20 pm »
Quote

Even though I have a download limit per day set in admin - they can simply press download on each of the open tabs and gain access to each download bypassing any limits I have set.
I don't see how that is possible.... I looked at the code it calls the Downloads_DownloadFile file in Downloads2.php and that handles all the checks before the file can be downloaded.
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline elbeer

  • Downloads Pro Customer
  • Full Member
  • *****
  • Posts: 111
    • View Profile
Re: Bypass Download Limit Bug
« Reply #2 on: March 19, 2015, 03:17:04 am »
The checks are done when you open the download page. So if you open 20 download pages and dont actually download anything until all 20 tabs are open you can download as many files as you like.

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 16436
    • View Profile
Re: Bypass Download Limit Bug
« Reply #3 on: March 19, 2015, 08:05:45 am »
But you shouldn't be able to download the files though... You might be able to open the pages to view download page but not actually download the files.
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline elbeer

  • Downloads Pro Customer
  • Full Member
  • *****
  • Posts: 111
    • View Profile
Re: Bypass Download Limit Bug
« Reply #4 on: March 23, 2015, 10:17:09 am »
But you can. If you open the download page without actually clicking download the link is rendered but is not counted. If you open up multiple pages where the links are rendered you can then download each file without checking the amount of downloads.

 

Related Topics

  Subject / Started by Replies Last post
2 Replies
3182 Views
Last post July 09, 2007, 11:13:26 pm
by rumboogy
3 Replies
6259 Views
Last post February 08, 2008, 01:39:16 am
by rtyug
1 Replies
5289 Views
Last post February 07, 2008, 09:59:50 pm
by rtyug
3 Replies
6626 Views
Last post May 19, 2008, 08:30:12 pm
by ApplianceJunk
3 Replies
3703 Views
Last post December 09, 2010, 10:43:34 am
by SMFHacks

+- Recent Topics

Problems SMF 2.0.19 > 2.1.4 SMF Gallery Pro - Recents Images to overall header by Michel68
Today at 08:27:36 am

No thumbnails on new uploads by Tonyvic
Today at 06:26:18 am

Display the Contact Page for guests by SMFHacks
March 27, 2024, 10:55:43 am

is it possible to add support for odysee.com by fvlog19
March 21, 2024, 08:47:51 am

Request for admin notification by davejo
March 10, 2024, 01:31:59 am

I need help with torrent upload by Ineedsmfhelp
March 09, 2024, 10:01:13 pm

an idea for new mod (( content type with different display )) by SMFHacks
February 27, 2024, 01:36:27 pm

[Mod] RSS Feed Poster by SMFHacks
February 27, 2024, 11:57:18 am

find duplicate pictures by fvlog19
February 14, 2024, 02:22:40 pm

Error uploading video. by SMFHacks
February 08, 2024, 02:04:16 pm

Powered by EzPortal