[Urgent] What happens to CheckGroupExpire if index.php gets hit hard per second

[shuban]

In CheckGroupExpire, I have changed it in such a way so it charges members who are set to subscription via Stripe. Once it charges them, their time stamp in group_log time increases so they're not deleted from their membergroup.

However, I'm finding that sometimes the same member gets charged 4,5,6 times in one shot -- very bad! My question is, could index.php have something to do with it? Since the website it accessed many times per second, the function gets activated before it realizes that the time has been changed by updateSettings.

Is that a possiblity? And, if that's the case, could I start using cron jobs so that I activates the function precisely once every 30 minutes?

[SMFHacks]

I wouldn't put in the index.php. I would put inside another script then call that script via a cron job. Maybe once a minute or so

[shuban]

I created a cron instead. So you're telling me this is probably was the cause?

[SMFHacks]

Yes could be a race condition if you have many people hit the same page at one time the code gets executed multiple times until the condition is no longer valid.

[shuban]

Yes could be a race condition if you have many people hit the same page at one time the code gets executed multiple times until the condition is no longer valid.

Thanks bro