sql syntax error populating the error log at the rapid rate

[drewactual]

Database Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 4Apply Filter: Only show the errors from this file File: /xxxxxx/Sources/adseller2.php
Line: 2543

thoughts on this? 

[SMFHacks]

Can you post what is on that line on the file . Doesn't' seem to matchup with my version. Post a coupleines

[drewactual]

Code: [Select]

// Get other places revshare chance
2533: $num =  rand(1,100);
2534:
2535: if ($num <= $AdSellerSettings['seller_revshare_other_chance'])
2536: {
2537: $showRevshare = true;
2538:
2539: $resultTopic = $smcFunc['db_query']('', "
2540: SELECT
2541: ID_MEMBER_STARTED
2542: FROM {db_prefix}topics
==>2543: WHERE ID_TOPIC = $topic");
2544: $topicRow = $smcFunc['db_fetch_assoc']($resultTopic);
2545: if (!empty($topicRow['ID_MEMBER_STARTED']))
2546: $topicSQLQuery = ' AND a.ID_MEMBER = ' . $topicRow['ID_MEMBER_STARTED'];
2547: }
2548: }
2549:
2550: if ($showRevshare == true)
2551: {
2552: $boardCheck = '';
2553: $revShareQuery = ' AND a.isRevShare = 1  ' . $topicSQLQuery;
2554: // allowrevshare
2555: }
2556: }
2557: // End Revenue Sharing
i/m a wittle bitty bear in deez woods.... i can likely do what you ask, but can't make any sense of this on my own

[SMFHacks]

before

Code: [Select]

$showRevshare = true;
2538:
2539: $resultTopic = $smcFunc['db_query']('', "
Add

Code: [Select]

$topic = (int) $topic;


[drewactual]

i'll let you know how it goes or what happens... I made the alteration, but now it'll be a matter of monitoring the error log to see if it strikes again.... I don't know how to test it.

[drewactual]

this worked without hitch... thank you, Sir, for the outstanding support!

[drewactual]

seeing another error I can't make heads or tales of.... line 1503 from the snippet below:

Code: [Select]

1493: // Get Total Pages
1494: $dbresult = $smcFunc['db_query']('', "
1495: SELECT
1496: COUNT(*) AS total
1497: FROM {db_prefix}seller_ad 
1498: WHERE removed = 0
1499: ");
1500: $row = $smcFunc['db_fetch_assoc']($dbresult);
1501: $numofrows = $row['total'];
1502: $smcFunc['db_free_result']($dbresult);
==>1503: $context['start'] = (int) $_REQUEST['start'];
1504:
1505: $dbresult = $smcFunc['db_query']('', "
1506: SELECT
1507: a.ID_AD, a.title, a.approved, a.ID_MEMBER, a.total_views, a.impressionslimit,
1508: a.clickslimit, a.total_clicks, a.isrevshare, m.real_name, a.adtype, a.maximpressionsperday ,
1509: a.todayimpressions, a.enddate     
1510: FROM {db_prefix}seller_ad AS a
1511: LEFT JOIN {db_prefix}members AS m ON (a.ID_MEMBER = m.ID_MEMBER)
1512: WHERE a.removed = 0
1513: ORDER BY a.ID_AD DESC
1514: LIMIT $context[start],10
1515: ");
1516: $styleClass = 'windowbg';
1517: while($row = $smcFunc['db_fetch_assoc']($dbresult))
1518: {
1519:
1520: $approvalStatus = $txt['seller_text_pending'];
1521:
1522: if ($row['approved'] == 1)
1523: $approvalStatus = $txt['seller_text_approved'];
it say's "call to undefined index"....

[SMFHacks]

Try  find

Code: [Select]

$context['start'] = (int) $_REQUEST['start'];
Change to

Code: [Select]

if (isset($_REQUEST['start'] ))
$context['start'] = (int) $_REQUEST['start'];
else
$context['start']  = 0;


[drewactual]

thank you, Sir.... will do this afternoon. 

[drewactual]

the error moved, but....

Code: [Select]

// Get Total Pages
1497: $dbresult = $smcFunc['db_query']('', "
1498: SELECT
1499: COUNT(*) AS total
1500: FROM {db_prefix}seller_ad 
1501: WHERE removed = 0
1502: ");
1503: $row = $smcFunc['db_fetch_assoc']($dbresult);
1504: $numofrows = $row['total'];
1505: $smcFunc['db_free_result']($dbresult);
==>1506: $context['start'] = (int) $_REQUEST['start'];
1507:
1508: $dbresult = $smcFunc['db_query']('', "
1509: SELECT
1510: a.ID_AD, a.title, a.approved, a.ID_MEMBER, a.total_views, a.impressionslimit,
1511: a.clickslimit, a.total_clicks, a.isrevshare, m.real_name, a.adtype, a.maximpressionsperday ,
1512: a.todayimpressions, a.enddate     
1513: FROM {db_prefix}seller_ad AS a
1514: LEFT JOIN {db_prefix}members AS m ON (a.ID_MEMBER = m.ID_MEMBER)
1515: WHERE a.removed = 0
1516: ORDER BY a.ID_AD DESC
1517: LIMIT $context[start],10
1518: ");
1519: $styleClass = 'windowbg';
1520: while($row = $smcFunc['db_fetch_assoc']($dbresult))
1521: {
1522:
1523: $approvalStatus = $txt['seller_text_pending'];
1524:
1525: if ($row['approved'] == 1)
1526: $approvalStatus = $txt['seller_text_approved'];
"undefined index: Start"

however, now the app is telling me I need to update, so.... I'm just going to do that first- I need to remove the prior version first, correct?

[SMFHacks]

You can update but remember you have to redo those changes we have above.

Also for the $context['start'] = (int) $_REQUEST['start'];  fix you must replace that code with the one I had above on line 1506

[drewactual]

hold up now- so I'm clear... just on 1506 or in every instance it appears?

[SMFHacks]

just 1506

[drewactual]

thank you, Sir..  I'm beginning to see a trend here.. I updated from 2.0.12 through 2.0.13 to 2.0.14.. the last one while upgrading to php7 and a more robust server and SSL... I'm thinking I keep running into head-butts with another package. 

[drewactual]

these are still related to ad pro....

Code: [Select]

echo $tab_context['title'], '
</span>';
}
else
{
echo '
', $tab_context['title'];
}

echo '
</h3>
</div>';

// Shall we use the tabs?
if (!empty($settings['use_tabs']))
{
echo '
<p class="windowbg description">
', !empty($selected_tab['description']) ? $selected_tab['description'] : $tab_context['description'], '
</p>';


lines 291 and 303- the error's are:

Apply Filter: Only show the error messages of this URLhttps://www.xxx.com/index.php?action=admin;area=adpro;sa=reports&id=54Apply Filter: Only show the errors with the same message8: Undefined index: descriptionApply Filter: Only show the errors from this file File: /home/cfb51com/public_html/Themes/default/GenericMenu.template.php
Line: 303

https://www.xxx.com/index.php?action=admin;area=adpro;sa=reports&id=54Apply Filter: Only show the errors with the same message8: Undefined index: titleApply Filter: Only show the errors from this file File: /home/cfb51com/public_html/Themes/default/GenericMenu.template.php
Line: 291

I'm terribly sorry to keep beating on this... It's just I'm lost on it.