Facebook  Twitter 

SMFHacks.com

+- +-

SMFHacks.com

+- User Information

Welcome, Guest.
Please login or register.
 
 
 
Forgot your password?

+- Forum Stats

Members
Total Members: 12371
Latest: wkingyork
New This Month: 2
New This Week: 1
New Today: 1
Stats
Total Posts: 40210
Total Topics: 7081
Most Online Today: 89
Most Online Ever: 2482
(April 09, 2011, 07:02:45 pm)
Users Online
Members: 0
Guests: 19
Total: 19

Author Topic: Pretty URLs and 2.1  (Read 1372 times)

0 Members and 1 Guest are viewing this topic.

Offline Oldiesmann

  • SMF Gallery Pro Customer
  • Newbie
  • *****
  • Posts: 15
    • View Profile
    • Archie Comics Fan Forum
Pretty URLs and 2.1
« on: February 18, 2019, 07:01:54 pm »
On my forum, when I enable URL rewriting, the form in the login popup never loads, even if I disable rewriting of the login action.

I get this error in the console in Chrome:

Code: [Select]
script.js:1016 Uncaught TypeError: Cannot use 'in' operator to search for 'addEventListener' in undefined
    at createEventListener (script.js:1016)
    at (index):402
createEventListener @ script.js:1016
(anonymous) @ (index):402

Apparently something is calling createEventListener without specifying an object. I haven't had time to dig into this further though.

Offline Oldiesmann

  • SMF Gallery Pro Customer
  • Newbie
  • *****
  • Posts: 15
    • View Profile
    • Archie Comics Fan Forum
Re: Pretty URLs and 2.1
« Reply #1 on: February 18, 2019, 07:06:50 pm »
I should note that this still happens even when using the most recent version of the mod.

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 15105
    • View Profile
Re: Pretty URLs and 2.1
« Reply #2 on: February 18, 2019, 07:52:58 pm »
From what I find on my test site it strips out the ; for this statement  which is strange.
So i added this code in the filter section to place it back... but that is a band aid.
Code: [Select]
$buffer = str_replace('javascript:self.close()"','javascript:self.close();"',$buffer);

I am still trying to narrow it down..
« Last Edit: February 18, 2019, 07:55:55 pm by SMFHacks »
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline Oldiesmann

  • SMF Gallery Pro Customer
  • Newbie
  • *****
  • Posts: 15
    • View Profile
    • Archie Comics Fan Forum
Re: Pretty URLs and 2.1
« Reply #3 on: February 18, 2019, 08:24:33 pm »
What file do I add that in?

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 15105
    • View Profile
Re: Pretty URLs and 2.1
« Reply #4 on: February 18, 2019, 08:44:40 pm »
I had it in Pretty-Urls-Filter.php

After
Code: [Select]
// Put the URLs back into the buffer
$context['pretty']['replace_patterns'][] = '~(<a[^>]+href=|<link[^>]+href=|<form[^>]+?action=)(\"[^\"]+\"|\'[^\']+\')~';
foreach ($context['pretty']['replace_patterns'] as $pattern)
$buffer = preg_replace_callback($pattern, 'pretty_buffer_callback', $buffer);
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline Oldiesmann

  • SMF Gallery Pro Customer
  • Newbie
  • *****
  • Posts: 15
    • View Profile
    • Archie Comics Fan Forum
Re: Pretty URLs and 2.1
« Reply #5 on: February 18, 2019, 09:39:38 pm »
That fixed it. Thanks!

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 15105
    • View Profile
Re: Pretty URLs and 2.1
« Reply #6 on: February 18, 2019, 09:40:57 pm »
It's very strange for two reasons one that the ; gets stripped out to.
And second that the ; makes a difference!
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 15105
    • View Profile
Re: Pretty URLs and 2.1
« Reply #7 on: March 07, 2019, 11:23:09 pm »
I think also fixed email notifications issue for 2.1
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

 

Related Topics

  Subject / Started by Replies Last post
4 Replies
3809 Views
Last post September 11, 2010, 06:21:10 am
by Wickedgood
4 Replies
4014 Views
Last post December 13, 2010, 07:05:12 pm
by SMFHacks
12 Replies
5713 Views
Last post April 07, 2012, 08:25:21 am
by SMFHacks
2 Replies
7077 Views
Last post June 21, 2012, 08:16:38 am
by mjindustry
30 Replies
3044 Views
Last post April 10, 2019, 01:17:37 pm
by SMFHacks

+- Recent Topics

Download System Lite by Rock Lee
June 03, 2020, 07:34:24 pm

Font question by SMFHacks
May 27, 2020, 08:15:26 am

Error message with latest SMF 2.1 Github build by Hatshepsut
May 25, 2020, 01:43:26 am

smfblog not working on 2.0.17 by tech9
May 20, 2020, 01:44:34 pm

Copyright removal by stbc
May 18, 2020, 01:27:57 am

Mod Verified User i can't square the image by Rock Lee
May 07, 2020, 07:56:10 pm

SMF4Mobile 2.0 released for SMF 2.0.x by SMFHacks
May 06, 2020, 12:13:14 pm

SMF Social Login Pro - Discontinued? by Nicole
May 02, 2020, 05:47:04 pm

Likes by SMFHacks
April 30, 2020, 09:50:35 pm

Upgrade Issue - by SMFHacks
April 28, 2020, 12:40:13 pm

Powered by EzPortal