Facebook  Twitter 

SMFHacks.com

+- +-

SMFHacks.com

+- User Information

Welcome, Guest.
Please login or register.
 
 
 
Forgot your password?

+- Forum Stats

Members
Total Members: 12424
Latest: serbenfiquista
New This Month: 5
New This Week: 0
New Today: 0
Stats
Total Posts: 40043
Total Topics: 7047
Most Online Today: 66
Most Online Ever: 2482
(April 09, 2011, 07:02:45 pm)
Users Online
Members: 0
Guests: 20
Total: 20

Author Topic: Pretty URLs and 2.1  (Read 1091 times)

0 Members and 1 Guest are viewing this topic.

Offline Oldiesmann

  • Newbie
  • *
  • Posts: 15
    • View Profile
    • Archie Comics Fan Forum
Pretty URLs and 2.1
« on: February 18, 2019, 07:01:54 pm »
On my forum, when I enable URL rewriting, the form in the login popup never loads, even if I disable rewriting of the login action.

I get this error in the console in Chrome:

Code: [Select]
script.js:1016 Uncaught TypeError: Cannot use 'in' operator to search for 'addEventListener' in undefined
    at createEventListener (script.js:1016)
    at (index):402
createEventListener @ script.js:1016
(anonymous) @ (index):402

Apparently something is calling createEventListener without specifying an object. I haven't had time to dig into this further though.

Offline Oldiesmann

  • Newbie
  • *
  • Posts: 15
    • View Profile
    • Archie Comics Fan Forum
Re: Pretty URLs and 2.1
« Reply #1 on: February 18, 2019, 07:06:50 pm »
I should note that this still happens even when using the most recent version of the mod.

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 15025
    • View Profile
Re: Pretty URLs and 2.1
« Reply #2 on: February 18, 2019, 07:52:58 pm »
From what I find on my test site it strips out the ; for this statement  which is strange.
So i added this code in the filter section to place it back... but that is a band aid.
Code: [Select]
$buffer = str_replace('javascript:self.close()"','javascript:self.close();"',$buffer);

I am still trying to narrow it down..
« Last Edit: February 18, 2019, 07:55:55 pm by SMFHacks »
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline Oldiesmann

  • Newbie
  • *
  • Posts: 15
    • View Profile
    • Archie Comics Fan Forum
Re: Pretty URLs and 2.1
« Reply #3 on: February 18, 2019, 08:24:33 pm »
What file do I add that in?

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 15025
    • View Profile
Re: Pretty URLs and 2.1
« Reply #4 on: February 18, 2019, 08:44:40 pm »
I had it in Pretty-Urls-Filter.php

After
Code: [Select]
// Put the URLs back into the buffer
$context['pretty']['replace_patterns'][] = '~(<a[^>]+href=|<link[^>]+href=|<form[^>]+?action=)(\"[^\"]+\"|\'[^\']+\')~';
foreach ($context['pretty']['replace_patterns'] as $pattern)
$buffer = preg_replace_callback($pattern, 'pretty_buffer_callback', $buffer);
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline Oldiesmann

  • Newbie
  • *
  • Posts: 15
    • View Profile
    • Archie Comics Fan Forum
Re: Pretty URLs and 2.1
« Reply #5 on: February 18, 2019, 09:39:38 pm »
That fixed it. Thanks!

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 15025
    • View Profile
Re: Pretty URLs and 2.1
« Reply #6 on: February 18, 2019, 09:40:57 pm »
It's very strange for two reasons one that the ; gets stripped out to.
And second that the ; makes a difference!
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

Offline SMFHacks

  • Administrator
  • Hero Member
  • *****
  • Posts: 15025
    • View Profile
Re: Pretty URLs and 2.1
« Reply #7 on: March 07, 2019, 11:23:09 pm »
I think also fixed email notifications issue for 2.1
Get your Forum Ranked! at https://www.forumrankings.net - find out how your forum compares with others!

Like What I do? Support me at https://www.patreon.com/vbgamer45/

 

Related Topics

  Subject / Started by Replies Last post
4 Replies
3701 Views
Last post September 11, 2010, 06:21:10 am
by Wickedgood
4 Replies
3893 Views
Last post December 13, 2010, 07:05:12 pm
by SMFHacks
12 Replies
5543 Views
Last post April 07, 2012, 08:25:21 am
by SMFHacks
2 Replies
6959 Views
Last post June 21, 2012, 08:16:38 am
by mjindustry
30 Replies
2442 Views
Last post April 10, 2019, 01:17:37 pm
by SMFHacks

+- Recent Topics

SMF Store 4.0 Released by SMFHacks
January 26, 2020, 12:11:56 pm

Order of photos by D4611001
January 21, 2020, 12:06:36 pm

Cannot install by SMFHacks
January 18, 2020, 09:40:56 pm

Call to undefined function mysql_query() by SMFHacks
January 18, 2020, 02:06:47 pm

English British Translation file by HAL9000
January 17, 2020, 05:44:28 pm

Characters dispayed as boxes by SMFHacks
January 16, 2020, 07:21:51 am

Multiple adds where one used to be? by SMFHacks
January 07, 2020, 08:20:38 am

Ribbon Theme Logo Position by slizzie1986
January 06, 2020, 08:52:31 pm

System enhancement? by SMFHacks
January 03, 2020, 09:22:45 am

Pretty Url Pro Is it compatible with 7.2? by Rock Lee
January 01, 2020, 08:53:50 pm

Powered by EzPortal