Error on the latest version

[davejo]

Hi,

Sorry to say there is an error with the new version of the downloads.

The site is using
SMF 2.0.17
Sources 2.0.17
Default Templates 2.0.16
Language Files 2.0.16
Current Templates ?
PHP ea-php73

I have listed all errors below as they are different in some way whether it be the line number or the actual error itself.

I have since reverted back to the previous 'Downloads2.php' file and everything is working fine

Code: [Select]

Database Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''Array''

WHERE ID_FILE = 11111 LIMIT 1' at line 4

UPDATE smf_down_file

allowcomments = 1, sendemail = 0, approved = 1,
fileurl = 'http://www.filefactory.com/file.rar',filesize = 'Array''

###################

https://www..net/index.php?action=downloads&sa=add2
2: get_headers():
This function may only be used against URLs
File: /home4//public_html/Sources/Downloads2.php
Line: 12242

###################
https://www..net/index.php?action=downloads&sa=add2
2: array_change_key_case() expects parameter 1 to be array, bool given
File: /home4//public_html/Sources/Downloads2.php
Line: 12242

###################

https://www..net/index.php?action=downloads&sa=edit2
8: Array to string conversion
File: /home4//public_html/Sources/Downloads2.php
Line: 2581

###################

https://www..net/index.php?action=downloads&sa=edit2
8: Array to string conversion
File: /home4//public_html/Sources/Downloads2.php
Line: 2591

[Hatshepsut]

I get similar error with latest 5.0.3 version. I am using SMF 2.1 RC3

Code: [Select]

Database Error
You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ''0''

WHERE ID_FILE = 3988 LIMIT 1' at line 4
File: /home/bulataka/public_html/BNF/Sources/Downloads2.php
Line: 2595
I get this error message when I'm editing a download item and trying to change its category.

[SMFHacks]

I think it requires allow_url_fopen to be set

http://www.php.net/manual/en/filesystem.configuration.php#ini.allow-url-fopen


I am posting a fix that checks for this now and some other checks on remotefilesize

[Hatshepsut]

Do I need to set allow_url_fopen to ON ? And what about allow_url_include ?
My forum works on PHP 7.4 and both options are set to OFF

I have installed new 5.0.3a version, but still get the same error.
 

[SMFHacks]

Just posted an updated to fix your last error. Missed one spot.

You should have allow_url_fopen if you want to counte remotely linked filesize

[Hatshepsut]

Thanks for the fix, the error is gone

[davejo]

I've uploaded the new file and posted tests.

I now have different errors.

The file link I'm posting is

Code: [Select]

http://www.filefactory.com/file/2e7ncs6ezz2n/Dark.Paths_Liberation.War.Book.4.rar Feel free to edit this if you want to but I thought under the circumstances you should see the whole link posted

Then the image I'm adding to the post is [ Guests cannot view attachments ]

The errors are

[ Guests cannot view attachments ] [ Guests cannot view attachments ]

Now I have to admit I didn't uninstall the whole mod as I only changed the 'Downloads2.php' file from the last update which is the one that gave the original error.

It's also worth noting that I changed the folder limit to 3 and posted 4 times and the folder didn't change.

Reverting back to the the previous 'Downloads2.php' v5.0c file gives the same error but it only seems to be with .gif images, if I post a .jpg image the error doesn't occur

[SMFHacks]

Looks like w arning errors resizing animated gifs. Does your gif still get resized?

[davejo]

Looks like w arning errors resizing animated gifs. Does your gif still get resized?

It doesn't seem to no, the gif I posted is a static gif, it's not animated

[SMFHacks]

Can you send the orginal file? The one above doesn't seem animated either. I might need to find a new resize gif class though as this one used is very old.

[davejo]

Can you send the orginal file? The one above doesn't seem animated either. I might need to find a new resize gif class though as this one used is very old.

I sent you a pm..it might help

[davejo]

I/m not sure if you saw the previous post or the PM so here is the gif.

If you're not going to go to the test site can you let me know and I'll delete it.

[SMFHacks]

You can get rid of the test site. The issue is with certain animated gifs.when they are resized.

[davejo]

You can get rid of the test site. The issue is with certain animated gifs.when they are resized.

Ok thanks for letting me know