Gallery Pro v8.0 and PHP 7.4

[FJCC]

I'm using Gallery Pro v8.0 (I know it's not the latest version) and when I started testing it with PHP 7.4 the following error message was logged for ./Sources/Gallery2.php
php 7.4 implode(): Passing glue string after array is deprecated. Swap the parameters.

I implemented the following fix throughout the file (there are five occurrences of the following code):
Find:

Code: [Select]

$groupsdata = implode($user_info['groups'], ',');
Replace With:

Code: [Select]

$groupsdata = implode(',', $user_info['groups']);

[SMFHacks]

Yes, that was one of the changes required.

Those changes are in our latest build: Here is a changelog since 8.0

9.0 beta 2
!Fixes for PHP 7.4+
+Added auto rotation based on EXIF settings. If EXIF is enabled.
+Look and feel updates for SMF 2.1.x
!Fix performance for recent comments block added index for large galleries
!Fixed a SQL error bug deleting a comment from the moderation section

8.0.8
!Fixed move picture to different category dropdown on category display.

8.0.7
!Fixed bug in some cases not allowing a single file to be uploaded.
+Improved watermark handling keeping orginal files.

8.0.6
!Must Update. Fix security issue with Local/Remote FLV fusing player_flv_maxi.swf FLV Player.
Have removed the option to play FLV videos. Make sure this file is removed gallery/videos/player_flv_maxi.swf from your forum

8.0.5
!Fixed bulk add link for user galleries when using the main menu
!Removed aviary settings since Adobe ended the product


8.0.4
!Fixed undefined gallery_picture_id on who favorited page for SMF 2.1.x
!Fixed undefined issue send pm online/offline buttons for SMF 2.1.x

8.0.3
!Fixed top button add picture select user gallery feature not working on some cases
!Fixed on add picture error for user gallery to keep user categories loaded in SMF 2.0.x
!Email notifications now add message-id header for SMF 2.0.x
!When getting the tinypic url check that allow_fopen is enabled


8.0.2
!Do not allow downloads of linked video files
!Mootools for image box is now supported over https://
!Avairy image affects script now supported over https://

8.0.1
!Fixed bug with rebuilding related index with 's characters in the title

[FJCC]

Thanks - I'll contact the forum owner and suggest that he pay for an upgrade.

[SMFHacks]

Sounds good yeah you can always upgrade at any time for $25 to get the latest updates for another year.

[Michel68]

Today I switched from PHP 7.3 to 7.4 and go the same error while I want to view the Error Logs in 

/Sources/Load.php

Code: [Select]

//Start SMF Gallery
if (allowedTo('smfgallery_view'))
{
global $sourcedir ;
require_once($sourcedir . '/Subs-Gallery2.php');

if (!$context['user']['is_guest'])

$groupsdata = implode($user_info['groups'], ',');


replace last line with :

Code: [Select]

                $groupsdata = implode(',',$user_info['groups']);

[Michel68]

I forgot to say that I am already on 9.0b and the error was stil there.

[SMFHacks]

It would only be fixed if you uninstall the old version completely as that code is a file edit that remains.